String backed strongly typed IDs by Dragemil · Pull Request #809 · leancodepl/corelibrary

Dragemil · 2025-12-17T14:04:19Z

github-actions · 2025-12-17T14:09:21Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
847	846	0	1	0	0	1m 55s

Skipped

Tests	Status
LeanCode.Azure.Tests.AzureStorageAuditLogIntegrationTests.Ensure_that_all_logs_are_correctly_uploaded_to_multiple_files	skipped ⏭️

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

codecov · 2025-12-17T14:09:33Z

Codecov Report

❌ Patch coverage is 97.36070% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.36%. Comparing base (b67c025) to head (fa4074e).

Files with missing lines	Patch %	Lines
...omain/LeanCode.DomainModels.Generators/IdSource.cs	97.41%	6 Missing and 1 partial ⚠️
...main/LeanCode.DomainModels/Ids/TypedIdAttribute.cs	0.00%	1 Missing ⚠️
...main/LeanCode.DomainModels/Ids/TypedIdConverter.cs	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           v10.0-preview     #809      +/-   ##
=================================================
+ Coverage          80.07%   81.36%   +1.29%     
=================================================
  Files                231      231              
  Lines               4356     4648     +292     
  Branches             344      340       -4     
=================================================
+ Hits                3488     3782     +294     
+ Misses               784      783       -1     
+ Partials              84       83       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR introduces string-backed strongly typed IDs to the DomainModels library, adding two new TypedId formats: RawString and PrefixedString. These complement the existing numeric and GUID-based ID types, allowing developers to use arbitrary string values as typed identifiers with optional length constraints.

Key Changes:

Added RawString and PrefixedString formats to TypedIdFormat enum (renumbering existing values)
Introduced MaxValueLength property to TypedIdAttribute for validating string length constraints
Implemented new IRawStringTypedId<TSelf> interface and RawStringTypedIdConverter<TId> for JSON serialization

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`src/Domain/LeanCode.DomainModels/Ids/TypedIdAttribute.cs`	Added `RawString` and `PrefixedString` enum values; added `MaxValueLength` property with documentation
`src/Domain/LeanCode.DomainModels/Ids/ITypedId.cs`	Introduced `IRawStringTypedId<TSelf>` interface for string-backed typed IDs
`src/Domain/LeanCode.DomainModels/Ids/TypedIdConverter.cs`	Added `RawStringTypedIdConverter<TId>` for JSON serialization of string IDs
`src/Domain/LeanCode.DomainModels.Generators/TypedIdFormat.cs`	Updated enum to match the attribute changes
`src/Domain/LeanCode.DomainModels.Generators/TypedIdData.cs`	Added `MaxValueLength` property to generator data model
`src/Domain/LeanCode.DomainModels.Generators/TypedIdGenerator.cs`	Updated generator to extract and pass `MaxValueLength` from attributes
`src/Domain/LeanCode.DomainModels.Generators/IdSource.cs`	Implemented `BuildRawString` and `BuildPrefixedString` methods; refactored switch to expression
`test/Domain/LeanCode.DomainModels.Tests/Ids/ValidConstructTests.cs`	Added test cases for new string formats; added `MaxValueLength` parameter to existing tests
`test/Domain/LeanCode.DomainModels.Tests/Ids/RawStringTests.cs`	Comprehensive test coverage for `RawString` format including max length validation
`test/Domain/LeanCode.DomainModels.Tests/Ids/PrefixedStringTests.cs`	Comprehensive test coverage for `PrefixedString` format including prefix validation and max length

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Domain/LeanCode.DomainModels.Generators/IdSource.cs

src/Domain/LeanCode.DomainModels/Ids/TypedIdAttribute.cs

src/Domain/LeanCode.DomainModels.Generators/IdSource.cs

test/Domain/LeanCode.DomainModels.Tests/Ids/PrefixedStringTests.cs

src/Domain/LeanCode.DomainModels.Generators/IdSource.cs

test/Domain/LeanCode.DomainModels.Tests/Ids/PrefixedStringTests.cs

test/Domain/LeanCode.DomainModels.Tests/Ids/RawStringTests.cs

docs/domain/id/index.md

…engthTypedId interfaces

…, and Guid types

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Domain/LeanCode.DomainModels.EF/PropertyBuilderExtensions.cs

src/Domain/LeanCode.DomainModels.EF/PropertiesConfigurationBuilderExtensions.cs

docs/domain/id/index.md

test/Domain/LeanCode.DomainModels.Tests/Ids/RawStringTests.cs

…h support

Dragemil · 2025-12-19T11:47:14Z

Another flaky test, added a bug

…and improve validation

src/Domain/LeanCode.DomainModels.EF/PropertiesConfigurationBuilderExtensions.cs

Dragemil added 3 commits December 17, 2025 14:49

Support string raw and prefixed typed IDs

39d5eaa

Add language annotations for C# in strings for source generation code

9bf5c22

Rename MaxValuePartLength to MaxValueLength and update related logic

dc637b7

Dragemil requested review from Copilot and jakubfijalkowski December 17, 2025 14:04

Copilot started reviewing on behalf of Dragemil December 17, 2025 14:04 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Dragemil added 5 commits December 17, 2025 15:17

Update ID docs

714043b

Improve MaxValueLength documentation

d204aa2

Fix GetValuePart to handle Empty instance

3ba9c5e

Add MaxValueLength validation to FromValuePart and constructor

dd1f33b

Improve RawString parse error message

4f9a860

jakubfijalkowski reviewed Dec 18, 2025

View reviewed changes

docs/domain/id/index.md Show resolved Hide resolved

jakubfijalkowski approved these changes Dec 18, 2025

View reviewed changes

Dragemil added 5 commits December 18, 2025 12:37

Add language annotations for C# in strings for source generation code

5dcd7e0

Refactor typed ID structures to implement IConstSizeTypedId and IMaxL…

1cec43b

…engthTypedId interfaces

Add EF Core support for string-typed IDs with max length validation

0f2f8ed

Add integration tests for PrefixedUlidId

aa97bab

Enhance typed ID property builders to include comparers for int, long…

54ec58b

…, and Guid types

Dragemil requested review from Copilot and jakubfijalkowski December 18, 2025 14:57

Copilot started reviewing on behalf of Dragemil December 18, 2025 14:57 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

Dragemil added 2 commits December 19, 2025 11:35

Update documentation for IDs to correct MaxLength property name

1730e1f

Add IHasEmptyId interface and refactor typed ID EF builders max lengt…

ff35af7

…h support

Dragemil force-pushed the feature/string-typed-ids branch from f9b4726 to ff35af7 Compare December 19, 2025 11:30

Refactor string-typed ID implementation to unify max length handling …

6fc5c3d

…and improve validation

Dragemil added 2 commits December 22, 2025 14:30

Add tests for raw and prefixed string ID max value length requirement

839fe29

Address string typed IDs in changelog and fix their attribute XML docs

d8438b1

jakubfijalkowski approved these changes Dec 22, 2025

View reviewed changes

src/Domain/LeanCode.DomainModels.EF/PropertiesConfigurationBuilderExtensions.cs Show resolved Hide resolved

Dragemil added 2 commits December 22, 2025 16:42

Include strongly typed IDs in integration tests

cf1598a

Bring back AreFixedLength() ID column configurations for backcomp

fa4074e

Dragemil merged commit 11b35ca into v10.0-preview Dec 23, 2025
9 checks passed

Dragemil deleted the feature/string-typed-ids branch December 23, 2025 07:47

Conversation

Dragemil commented Dec 17, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Skipped

Uh oh!

codecov bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dragemil commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dragemil commented Dec 17, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

codecov bot commented Dec 17, 2025 •

edited

Loading